Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data-export] Large amount of suggestion fields is not scrollable #301

Closed
vranisimo opened this issue Feb 6, 2024 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@vranisimo
Copy link

vranisimo commented Feb 6, 2024

Describe the bug
When there is a large amount of object fields, the field suggestions is showing only the topmost fields and the view is not scrollable.

To Reproduce
Steps to reproduce the behavior:

  1. Go to data export
  2. Start with the normal SOQL select
  3. Click on the Show all suggestions button
  4. If there is a large amount of object fields, you can only see the top part of the fields section, and can't scroll to the bottom or to the results div/element.

Expected behavior
I would expect that all possible object fields are displayed in a scrollable html element. I noticed that all html elements for all fields are available in the DOM, but it is just not possible (without browser dev tools) to scroll or focus to them.

Screenshots
Fields are not previewed due to privacy, but there is a red rectangle indicator just to prove that a scrollbar is not present.
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Chrome
  • Version 121.0.6167.140 (the latest version at this moment)
@vranisimo vranisimo added the bug Something isn't working label Feb 6, 2024
tprouvot added a commit that referenced this issue Feb 6, 2024
## Describe your changes
Make data export suggestions scrollable

<img width="1434" alt="image"
src="https://github.com/tprouvot/Salesforce-Inspector-reloaded/assets/35368290/daa7c7e4-6776-4a6a-8566-6769065873f0">


## Issue ticket number and link
Close #301 

## Checklist before requesting a review
- [ ] I have read and understand the [Contributions
section](https://github.com/tprouvot/Salesforce-Inspector-reloaded#contributions)
- [ ] Target branch is releaseCandidate and not master
- [ ] I have performed a self-review of my code
- [ ] I ran the [unit
tests](https://github.com/tprouvot/Salesforce-Inspector-reloaded#unit-tests)
and my PR does not break any tests
- [ ] I documented the changes I've made on the
[CHANGES.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/CHANGES.md)
and followed actual conventions
- [ ] I added a new section on
[how-to.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/docs/how-to.md)
(optional)
@tprouvot
Copy link
Owner

tprouvot commented Feb 6, 2024

Will be available in 1.23 and earlier on beta version

@tprouvot tprouvot closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants