Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector does not work when Microsoft Defender for Cloud Apps is enabled #234

Closed
mehdicherf opened this issue Nov 24, 2023 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@mehdicherf
Copy link
Contributor

mehdicherf commented Nov 24, 2023

Hi,

When we are in a work environment that uses Microsoft Defender for Cloud Apps, the Inspector extension does not show.

That is because Microsoft Defender for Cloud Apps redirects the traffic through a .mcas.ms domain:

SalesforceURL

See also https://learn.microsoft.com/en-us/defender-cloud-apps/troubleshooting-proxy-url

@mehdicherf mehdicherf added the bug Something isn't working label Nov 24, 2023
@mehdicherf
Copy link
Contributor Author

mehdicherf commented Nov 24, 2023

I'll work on a PR for this issue.

@mehdicherf
Copy link
Contributor Author

mehdicherf commented Nov 30, 2023

Should be solved in the next version (#239)

Note: In that situation, the sid cookie is never usable by the extension, because the sid cookie available to the .mcas.ms domain is encrypted by Microsoft Defender for Cloud Apps, and cannot be used as-is.

This means that Microsoft Defender for Cloud Apps users must always use Salesforce Inspector with a Connected App.

With Microsoft Defender for Cloud Apps, a valid access token must be generated before using the extension.

tprouvot pushed a commit that referenced this issue Dec 1, 2023
## Describe your changes

This PR adds support for the `.mcas.ms` domain, which is used when the
org is protected behind [Microsoft Defender for Cloud
Apps](https://learn.microsoft.com/en-us/defender-cloud-apps/troubleshooting-proxy-url).

**Note**: In that situation, the `sid` cookie is never usable by the
extension, because the `sid` cookie available to the `.mcas.ms` domain
is encrypted by Microsoft Defender for Cloud Apps, and cannot be used
as-is.

This means that **Microsoft Defender for Cloud Apps users must always
[use Salesforce Inspector with a Connected
App](https://tprouvot.github.io/Salesforce-Inspector-reloaded/how-to/#use-sf-inspector-with-a-connected-app).**

With Microsoft Defender for Cloud Apps, a **valid access token must be
generated before using the extension**.


## Issue ticket number and link

Solves #234 

## Checklist before requesting a review
- [X] I have read and understand the [Contributions
section](https://github.com/tprouvot/Salesforce-Inspector-reloaded#contributions)
- [X] Target branch is releaseCandidate and not master
- [X] I have performed a self-review of my code
- [X] I ran the [unit
tests](https://github.com/tprouvot/Salesforce-Inspector-reloaded#unit-tests)
and my PR does not break any tests
- [X] I documented the changes I've made on the
[CHANGES.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/CHANGES.md)
and followed actual conventions
- [ ] I added a new section on
[how-to.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/docs/how-to.md)
(optional)

---------

Co-authored-by: Mehdi Cherfaoui <>
@tprouvot tprouvot closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants