Skip to content

Commit

Permalink
[fix] Show All data : Align Data Type with Salesforce (#312)
Browse files Browse the repository at this point in the history
## Describe your changes
Align Data Type in Inspector with Salesforce:

## Issue ticket number and link
#311 

## Checklist before requesting a review
- [x] I have read and understand the [Contributions
section](https://github.com/tprouvot/Salesforce-Inspector-reloaded#contributions)
- [x] Target branch is releaseCandidate and not master
- [x] I have performed a self-review of my code
- [x] I ran the [unit
tests](https://github.com/tprouvot/Salesforce-Inspector-reloaded#unit-tests)
and my PR does not break any tests
- [x] I documented the changes I've made on the
[CHANGES.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/CHANGES.md)
and followed actual conventions
- [ ] I added a new section on
[how-to.md](https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/master/docs/how-to.md)
(optional)
  • Loading branch information
tprouvot authored Feb 21, 2024
1 parent 3ecacf6 commit fb5fb0c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Version 1.23

- Align show-all data 'Type' column with Salesforce's 'Data Type' field [issue 312](https://github.com/tprouvot/Salesforce-Inspector-reloaded/issues/312) (issue by efcdilascio(https://github.com/efcdilascio))
- Make data export suggestions scrollable [feature 301](https://github.com/tprouvot/Salesforce-Inspector-reloaded/issues/301) (feature by Vranisimo(https://github.com/vranisimo))
- Show the number of filtered records in data export [feature 300](https://github.com/tprouvot/Salesforce-Inspector-reloaded/issues/300) (feature by Vranisimo(https://github.com/vranisimo))
- Hide RecType and Name field from popup when field is not set [feature 298](https://github.com/tprouvot/Salesforce-Inspector-reloaded/issues/298)
Expand Down
4 changes: 2 additions & 2 deletions addon/inspect.js
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ class FieldRow extends TableRow {
? "[" + fieldDescribe.referenceTo.join(", ") + "]"
: (fieldDescribe.type || "")
+ (fieldDescribe.length ? " (" + fieldDescribe.length + ")" : "")
+ (fieldDescribe.precision || fieldDescribe.scale ? " (" + fieldDescribe.precision + ", " + fieldDescribe.scale + ")" : "")
+ (fieldDescribe.precision || fieldDescribe.scale ? " (" + (fieldDescribe.precision - fieldDescribe.scale) + ", " + fieldDescribe.scale + ")" : "")
+ (fieldDescribe.autoNumber ? ", auto number" : "")
+ (fieldDescribe.caseSensitive ? ", case sensitive" : "")
+ (fieldDescribe.dependentPicklist ? ", dependent" : "")
Expand All @@ -667,7 +667,7 @@ class FieldRow extends TableRow {
? "[" + particle.ReferenceTo.referenceTo.join(", ") + "]"
: (particle.DataType || "")
+ (particle.Length ? " (" + particle.Length + ")" : "")
+ (particle.Precision || particle.Scale ? " (" + particle.Precision + ", " + particle.Scale + ")" : "")
+ (particle.Precision || particle.Scale ? " (" + (particle.Precision - particle.scale) + ", " + particle.Scale + ")" : "")
+ (particle.IsAutonumber ? ", auto number" : "")
+ (particle.IsCaseSensitive ? ", case sensitive" : "")
+ (particle.IsDependentPicklist ? ", dependent" : "")
Expand Down

0 comments on commit fb5fb0c

Please sign in to comment.