Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jpegoptim worker didn't strip comment #188

Closed
NaturalHokke opened this issue Dec 11, 2020 · 2 comments
Closed

jpegoptim worker didn't strip comment #188

NaturalHokke opened this issue Dec 11, 2020 · 2 comments

Comments

@NaturalHokke
Copy link

comment removal option is jpegoptim: { strip: [:comments] }
but jpegoptim's option is --strip-com
toy added a commit that referenced this issue Dec 14, 2020
@toy
fix and update jpegoptim list of markers, resolves #188
1cca582 
The `com` marker was listed as `comments` which didn't allow to pass it
to jpegoptim either causing a warning from the gem (if com was used) or
from the tool itself when it was receiving --strip-comments. Also add
missing `xmp` and `none`.
toy added a commit that referenced this issue Dec 14, 2020
@toy
fix and update jpegoptim list of markers, resolves #188
aae6f9f 
The `com` marker was listed as `comments` which didn't allow to pass it
to jpegoptim either causing a warning from the gem (if com was used) or
from the tool itself when it was receiving --strip-comments. Also add
missing `xmp` and `none`.
@toy
Copy link
Owner

toy commented Dec 14, 2020

Thank you for reporting, you completely right it should be just com.
So currently it is not possible to add --strip-com as using jpegoptim: { strip: [:comments] } will make jpegoptim warn and ignore the option and using jpegoptim: { strip: [:com] } will cause a warning from the gem and will not add the switch.
https://github.com/toy/image_optim/compare/jpegoptim-update-marker-list should fix this.

@toy toy closed this as completed in a3e177a Dec 18, 2020
@toy
Copy link
Owner

toy commented Dec 18, 2020

Released as part of v0.28.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@toy @NaturalHokke