Allow space-separated passenv variables #2628
Conversation
|
I think this might break the comma separated case 🤔, but it's my first stab. |
There was a problem hiding this comment.
This will not work, though. This is hacking it into, rather than supported by design. tox 4 no longer wants to be in the business of custom parsers per key that confuse new users. Any parsing logic needs to apply to all keys and must be done at the loader level, not in post-processing. The post-processing is reserved for transforming values to other types, not hacking in a custom parsing logic. Thanks for the try, though.
| values.extend(self._default_pass_env()) | ||
| return sorted({k: None for k in values}.keys()) |
There was a problem hiding this comment.
No operation might happen here because this is past the INI file loader: translation this will break a soon-to-add native pyproject.toml config intuitive behavior, which I'm not willing to put up with. You can't make changes to the INI file loader because that applies to all other keys, and e.g. for deps you don't want this. Hence my comment, this can't be done clearly, so I'm willing to make a breaking change.
|
Closing per my comment above. |
|
Thanks for the review @gaborbernat, still trying to wrap my head around the tox4 world, which is totally awesome! |
Fixes #2615
Thanks for contribution
Please, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix_lint)docs/changelogfolder