Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better selection support #2290

Merged
merged 5 commits into from
Jan 4, 2022
Merged

Conversation

gaborbernat
Copy link
Member

Signed-off-by: Bernát Gábor [email protected]

Signed-off-by: Bernát Gábor <[email protected]>
Copy link
Member

@jugmac00 jugmac00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

This should fix #238.

I have one minor inline comment.

Also, if possible, please add some documentation.

src/tox/session/env_select.py Outdated Show resolved Hide resolved
Signed-off-by: Bernát Gábor <[email protected]>
@gaborbernat gaborbernat force-pushed the better-sel branch 3 times, most recently from e14d703 to 997cd24 Compare January 4, 2022 08:46
Signed-off-by: Bernát Gábor <[email protected]>
@ericchansen
Copy link

I'm trying to learn how to use this feature, and I'm struggling. Is there any particular docs I should focus on? Or perhaps certain tests that demonstrate the feature well?

@gaborbernat
Copy link
Member Author

What you looking to achieve?

@jugmac00
Copy link
Member

I'm trying to learn how to use this feature, and I'm struggling. Is there any particular docs I should focus on? Or perhaps certain tests that demonstrate the feature well?

Does this link answer your question? https://tox.wiki/en/rewrite/config.html#labels

If not, please create an issue.

@ericchansen
Copy link

ericchansen commented Apr 25, 2022

@jugmac00, I read that before making this comment, but thank you!

@gaborbernat I want to create a new env that runs in almost the same way as the default env except it has more extras. I'll try to give a minimal example.

[tox]
envlist = py36, py37, py38, py39
minversion = 3.15

[testenv]
description = Invoke pytest to run automated tests
commands =
    pytest \
        --cov \
        --cov-append \
        --junitxml {toxworkdir}/junit.{envname}.xml \
        src/tests
        {posargs}
extras =
    testing
passenv =
    HOME
setenv =
    COVERAGE_FILE = {env:COVERAGE_FILE:{toxworkdir}/.coverage.{envname}}
    TOXINIDIR = {toxinidir}

[testenv:gitlab]
extras =
    gitlab
    testing

I want the gitlab env to do the same thing as the default env (run the tests on py36, py37, etc.), except also install a few more additional dependencies.

EDIT: Sorry, didn't see your updated comment which asked me to create a new issue. I will do so.

@jugmac00
Copy link
Member

jugmac00 commented Apr 25, 2022

Please do not hijack this pull request and create a discussion - thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants