Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix badge link and code formatting #2053

Merged
merged 3 commits into from
May 2, 2021
Merged

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented May 1, 2021

Thanks for contributing a pull request!

If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • [n/a] wrote descriptive pull request text
  • [n/a] added/updated test(s)
  • updated/extended the documentation
  • [n/a] added relevant issue keyword
    in message body
  • [n/a?] added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

Before the first badge linked to the badge image, now it links to PyPI.

Before the code didn't have coloured formatting on GitHub:

image

Afterwards it does:

image

Plus fix some little typos.

@jugmac00 jugmac00 self-requested a review May 2, 2021 02:18
Copy link
Member

@jugmac00 jugmac00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one typo? :-)

CONTRIBUTORS Outdated Show resolved Hide resolved
Co-authored-by: Jürgen Gmach <[email protected]>
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit 2d820ec into tox-dev:master May 2, 2021
@hugovk hugovk deleted the patch-1 branch November 15, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants