Remove redundant character escape in some regexes #2051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noviluni
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
eumiro
suggested changes
Apr 30, 2021
src/tox/package/local.py
Outdated
| @@ -49,7 +49,7 @@ def get_latest_version_of_package(package_spec): | |||
| return candidates[0] | |||
|
|
|||
|
|
|||
| _REGEX_FILE_NAME_WITH_VERSION = re.compile(r"[\w_\-\+\.]+-(.*)\.(zip|tar\.gz)") | |||
| _REGEX_FILE_NAME_WITH_VERSION = re.compile(r"[\w_\-+.]+-(.*)\.(zip|tar\.gz)") | |||
There was a problem hiding this comment.
How about moving that \- to beginning/end of the […] block to unescape it too?
There was a problem hiding this comment.
hey! good idea @eumiro
I updated the branch with this change 🙂
eumiro
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed that some regexes were hard to read because they had unnecessary escaping, so I cleaned them up.
After that, I run the tests and all passed. Let me know if there's anything you want to discuss. :)