Allow {posargs} in setenv #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
Escape {packages} and {opts} so they are literals
allowed only in `install_command`.
jayvdb
force-pushed
the
rm-install-command-special-cases
branch
from
08ee204 to
ad3d69f
Compare
jayvdb
force-pushed
the
rm-install-command-special-cases
branch
from
ad3d69f to
d3ef0b4
Compare
|
The changes re |
Closed
jayvdb
commented
Jan 11, 2021
| # special case: opts and packages. Leave {opts} and | ||
| # {packages} intact, they are replaced manually in | ||
| # _venv.VirtualEnv.run_install_command. | ||
| if sub_value in ("opts", "packages"): |
jayvdb
commented
Jan 11, 2021
| continue | ||
| elif word.startswith("{posargs:") and word.endswith("}"): |
There was a problem hiding this comment.
This case wasn't handled correctly in the new code, if : was in the middle of this text range, resulting in regression #1785
ssbarnea
pushed a commit
to ssbarnea/tox
that referenced
this pull request
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1695
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rstfor example (588.bugfix.rst)<type>is must be one ofbugfix,feature,deprecation,breaking,doc,misc<your username>"superuser."CONTRIBUTORS(preserving alphabetical order)