Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CallAll error type to Svc::Error #649

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Change CallAll error type to Svc::Error #649

merged 1 commit into from
Mar 9, 2022

Conversation

leoyvens
Copy link
Contributor

@leoyvens leoyvens commented Mar 9, 2022

This is a breaking change. I don't see a reason for CallAll to wrap the error in a BoxError.

davidpdrsn
davidpdrsn approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

hawkw
hawkw approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this seems good to me!

@davidpdrsn davidpdrsn merged commit 04f0bd0 into tower-rs:master Mar 9, 2022
@leoyvens leoyvens mentioned this pull request Mar 10, 2022
Merged
@leoyvens leoyvens deleted the call-all-service-error branch March 10, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

@davidpdrsn davidpdrsn davidpdrsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leoyvens @davidpdrsn @hawkw