Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
CA: don't error out in HintingSimulator if a hinted Node is gone
If a hinted Node is no longer in the cluster snapshot (e.g. it was a fake upcoming Node and the real one appeared). This was introduced in the recent PredicateChecker->PredicateSnapshot refactor. Previously, PredicateChecker.CheckPredicates() would return an error if the hinted Node was gone, and HintingSimulator treated this error the same as failing predicates - it would move on to the non-hinting logic. After the refactor, HintingSimulator explicitly errors out if it can't retrieve the hinted Node from the snapshot, so the behavior changed. I checked other CheckPredicates()/SchedulePod() callsites, and this is the only one when ignoring the missing Node makes sense. For the others, the Node is added to the snapshot just before the call, so it being missing should cause an error.
- Loading branch information