[fix] Show hidden custom inputs only to authenticated sessions #90
Conversation
RubLo
changed the title
|
We wanted to only hide the inputs of type "hidden" no? |
Ah thanks, understood now what you meant for type hidden, will update it |
RubLo
changed the title
apps/web/pages/booking/[uid].tsx
Outdated
| const showHiddenInputs = | ||
| eventTypeCustomFound?.type === "HIDDEN" && sessionStatus === "authenticated"; | ||
| if (!showHiddenInputs) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Wait, now you will only see hidden inputs when you are logged in and nothing else. Users that are not looked in will not see anything.
Shouldn't it be like
if (eventTypeCustomFound?.type === "HIDDEN" && sessionStatus !== "authenticated") {
return null;
}
There was a problem hiding this comment.
the 2 logics are equivalent, I do negate the result later with !showHiddenInputs.
I agree it's a bit hard to understand due to the !, but hideHiddenInputs was also weird naming.
I can remove the variable and do an inline check in the if statement if you prefer
There was a problem hiding this comment.
The conditions are not equivalent. Imagine type is "TEXT". Then showHiddenInputs is false and you will not render anything.
There was a problem hiding this comment.
It's Monday. My head works slow. But yes definitely if you just inline it without leading negation, it's easier to understand.
There was a problem hiding this comment.
if type is TEXT showHiddenInputs would be true and !showHiddenInputs evaluates as false
|
Let's also add this change to the "Notificable Changes" section of the Confluence page. |
Context/Change
Show custom inputs only to authenticated users, to prevent this scenario