add TOME_SCRIPT_ROOT environment variable #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having an environment variable that contains the script root directory enables storing dependent scripts in that directory. fixes #41.
tome run satisfies a use case where one would like to re-use tome's script navigation functionality, but in an environment that is not an interactive shell. This could be useful in a situation where one would like to share scripts across a local and deployed envioronment. tome run does an execve to effectively become the function invoked: although this is less cross-platform compatible, it results in the simplest method to reduce complications like buffer sizes handing off data in intermediary pipes. refactoring some finder logic out for re-use. fixes #40.
adding a test to verify new tome run behavior.
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having an environment variable that contains
the script root directory enables storing dependent scripts
in that directory.
fixes #41.