Merge pull request TeamNewPipe/NewPipe#5896 from Stypox/fix-error-panel

Fix error panel created in onViewCreated() but disposed in onDestroy()
tossj · Apr 22, 2021 · ec8feb9 · ec8feb9
1 parent b2f765f
commit ec8feb9
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/app/src/main/java/org/schabi/newpipelegacy/fragments/BaseStateFragment.java b/app/src/main/java/org/schabi/newpipelegacy/fragments/BaseStateFragment.java
@@ -56,12 +56,6 @@ public void onResume() {
         }
     }
 
-    @Override
-    public void onDestroy() {
-        super.onDestroy();
-        errorPanelHelper.dispose();
-    }
-
     /*//////////////////////////////////////////////////////////////////////////
     // Init
     //////////////////////////////////////////////////////////////////////////*/
@@ -74,6 +68,14 @@ protected void initViews(final View rootView, final Bundle savedInstanceState) {
         errorPanelHelper = new ErrorPanelHelper(this, rootView, this::onRetryButtonClicked);
     }
 
+    @Override
+    public void onDestroyView() {
+        super.onDestroyView();
+        if (errorPanelHelper != null) {
+            errorPanelHelper.dispose();
+        }
+    }
+
     protected void onRetryButtonClicked() {
         reloadContent();
     }