Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): remove the type that deleted the symbol which name is ObjectKeys. #215

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

okinawaa
Copy link
Member

Overview

Although the object's key value could be a symbol, the array of keys was blocked from entering the symbol.

I think I've limited it in the past because of this issue, but now the keyof command works well for the object to which the symbol belongs.

If there's any other reason why pick function blocked the symbol, please tell me!

Screenshot in my vscode

image

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

@netlify
Copy link

netlify bot commented Feb 21, 2023

👷 Deploy request for slash-libraries pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 56b3c9a

@okinawaa okinawaa changed the title feat(utils): Remove the type that deleted the symbol which name is ObjectKeys. feat(utils): remove the type that deleted the symbol which name is ObjectKeys. Feb 21, 2023
Copy link
Contributor

@hoseungme hoseungme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think we need ObjectKeys type when we use some utils which exclude Symbol like Object.keys.

But in pick, you are right. We don't have to exclude Symbol.

@hoseungme hoseungme changed the title feat(utils): remove the type that deleted the symbol which name is ObjectKeys. fix(utils): remove the type that deleted the symbol which name is ObjectKeys. Feb 22, 2023
@hoseungme hoseungme merged commit 828bd50 into toss:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants