Skip to content

Commit

Permalink
Merge pull request #168 from koic/enable_redundant_double_splat_hash_…
Browse files Browse the repository at this point in the history
…braces_cop

Enable `Style/RedundantDoubleSplatHashBraces` cop
  • Loading branch information
toshimaru authored Oct 19, 2023
2 parents cd5eeef + d82058b commit 42d6eb6
Show file tree
Hide file tree
Showing 13 changed files with 7 additions and 156 deletions.
10 changes: 1 addition & 9 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,7 @@ jobs:
matrix:
ruby: ['2.7', '3.0', '3.1', '3.2']
gemfile:
- gemfiles/rubocop_1.48.gemfile
- gemfiles/rubocop_1.49.gemfile
- gemfiles/rubocop_1.50.gemfile
- gemfiles/rubocop_1.51.gemfile
- gemfiles/rubocop_1.52.gemfile
- gemfiles/rubocop_1.53.gemfile
- gemfiles/rubocop_1.54.gemfile
- gemfiles/rubocop_1.55.gemfile
- gemfiles/rubocop_1.56.gemfile
- gemfiles/rubocop_1.57.gemfile
env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion Appraisals
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

SUPPORTED_VERSIONS = %w[1.48 1.49 1.50 1.51 1.52 1.53 1.54 1.55 1.56].freeze
SUPPORTED_VERSIONS = %w[1.57].freeze

SUPPORTED_VERSIONS.each do |version|
appraise "rubocop-#{version}" do
Expand Down
3 changes: 3 additions & 0 deletions config/rails.yml
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,9 @@ Style/TrivialAccessors:
Style/RedundantCondition:
Enabled: true

Style/RedundantDoubleSplatHashBraces:
Enabled: true

Performance/BindCall:
Enabled: true

Expand Down
18 changes: 0 additions & 18 deletions gemfiles/rubocop_1.49.gemfile

This file was deleted.

18 changes: 0 additions & 18 deletions gemfiles/rubocop_1.50.gemfile

This file was deleted.

18 changes: 0 additions & 18 deletions gemfiles/rubocop_1.51.gemfile

This file was deleted.

18 changes: 0 additions & 18 deletions gemfiles/rubocop_1.52.gemfile

This file was deleted.

18 changes: 0 additions & 18 deletions gemfiles/rubocop_1.53.gemfile

This file was deleted.

18 changes: 0 additions & 18 deletions gemfiles/rubocop_1.54.gemfile

This file was deleted.

18 changes: 0 additions & 18 deletions gemfiles/rubocop_1.55.gemfile

This file was deleted.

18 changes: 0 additions & 18 deletions gemfiles/rubocop_1.56.gemfile

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ gem "bundler"
gem "minitest"
gem "rake"
gem "rails", ">= 5.2"
gem "rubocop", "~> 1.48.0"
gem "rubocop", "~> 1.57.0"
# This is a workaround to prevent the following error in RuboCop Rails 2.21.2.
# https://github.com/toshimaru/rubocop-rails_config/actions/runs/6522833241/job/17712818757#step:4:85
# This gem specification can be removed once a version resolving the issue is released.
Expand Down
2 changes: 1 addition & 1 deletion rubocop-rails_config.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Gem::Specification.new do |spec|
spec.license = "MIT"
spec.required_ruby_version = ">= 2.7.0"

spec.add_dependency "rubocop", ">= 1.48.0"
spec.add_dependency "rubocop", ">= 1.57.0"
spec.add_dependency "rubocop-ast", ">= 1.26.0"
spec.add_dependency "rubocop-md"
spec.add_dependency "rubocop-minitest", "~> 0.22"
Expand Down

0 comments on commit 42d6eb6

Please sign in to comment.