Skip to content

Commit

Permalink
perf tools: Add thread_map__(alloc|realloc) helpers
Browse files Browse the repository at this point in the history
In order to have 'struct thread_map' allocation on single place and can
change it easily in following patch.

Using alloc|realloc for static helpers, because thread_map__new is
already used in public interface.

Signed-off-by: Jiri Olsa <[email protected]>
Cc: Adrian Hunter <[email protected]>
Cc: Andi Kleen <[email protected]>
Cc: David Ahern <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Stephane Eranian <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
  • Loading branch information
olsajiri authored and acmel committed Jun 16, 2015
1 parent b45f65e commit 9d7e8c3
Showing 1 changed file with 16 additions and 8 deletions.
24 changes: 16 additions & 8 deletions tools/perf/util/thread_map.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@ static int filter(const struct dirent *dir)
return 1;
}

static struct thread_map *thread_map__realloc(struct thread_map *map, int nr)
{
size_t size = sizeof(*map) + sizeof(pid_t) * nr;

return realloc(map, size);
}

#define thread_map__alloc(__nr) thread_map__realloc(NULL, __nr)

struct thread_map *thread_map__new_by_pid(pid_t pid)
{
struct thread_map *threads;
Expand All @@ -33,7 +42,7 @@ struct thread_map *thread_map__new_by_pid(pid_t pid)
if (items <= 0)
return NULL;

threads = malloc(sizeof(*threads) + sizeof(pid_t) * items);
threads = thread_map__alloc(items);
if (threads != NULL) {
for (i = 0; i < items; i++)
threads->map[i] = atoi(namelist[i]->d_name);
Expand All @@ -49,7 +58,7 @@ struct thread_map *thread_map__new_by_pid(pid_t pid)

struct thread_map *thread_map__new_by_tid(pid_t tid)
{
struct thread_map *threads = malloc(sizeof(*threads) + sizeof(pid_t));
struct thread_map *threads = thread_map__alloc(1);

if (threads != NULL) {
threads->map[0] = tid;
Expand All @@ -65,8 +74,8 @@ struct thread_map *thread_map__new_by_uid(uid_t uid)
int max_threads = 32, items, i;
char path[256];
struct dirent dirent, *next, **namelist = NULL;
struct thread_map *threads = malloc(sizeof(*threads) +
max_threads * sizeof(pid_t));
struct thread_map *threads = thread_map__alloc(max_threads);

if (threads == NULL)
goto out;

Expand Down Expand Up @@ -185,8 +194,7 @@ static struct thread_map *thread_map__new_by_pid_str(const char *pid_str)
goto out_free_threads;

total_tasks += items;
nt = realloc(threads, (sizeof(*threads) +
sizeof(pid_t) * total_tasks));
nt = thread_map__realloc(threads, total_tasks);
if (nt == NULL)
goto out_free_namelist;

Expand Down Expand Up @@ -216,7 +224,7 @@ static struct thread_map *thread_map__new_by_pid_str(const char *pid_str)

struct thread_map *thread_map__new_dummy(void)
{
struct thread_map *threads = malloc(sizeof(*threads) + sizeof(pid_t));
struct thread_map *threads = thread_map__alloc(1);

if (threads != NULL) {
threads->map[0] = -1;
Expand Down Expand Up @@ -253,7 +261,7 @@ static struct thread_map *thread_map__new_by_tid_str(const char *tid_str)
continue;

ntasks++;
nt = realloc(threads, sizeof(*threads) + sizeof(pid_t) * ntasks);
nt = thread_map__realloc(threads, ntasks);

if (nt == NULL)
goto out_free_threads;
Expand Down

0 comments on commit 9d7e8c3

Please sign in to comment.