Skip to content

Commit

Permalink
PCI: mt7621: Add sentinel to quirks table
Browse files Browse the repository at this point in the history
Current driver is missing a sentinel in the struct soc_device_attribute
array, which causes an oops when assessed by the
soc_device_match(mt7621_pcie_quirks_match) call.

This was only exposed once the CONFIG_SOC_MT7621 mt7621 soc_dev_attr
was fixed to register the SOC as a device, in:

commit 7c18b64 ("mips: ralink: mt7621: do not use kzalloc too early")

Fix it by adding the required sentinel.

Link: https://lore.kernel.org/lkml/[email protected]
Link: https://lore.kernel.org/r/[email protected]
Fixes: b483b4e ("staging: mt7621-pci: add quirks for 'E2' revision using 'soc_device_attribute'")
Signed-off-by: John Thomson <[email protected]>
Signed-off-by: Lorenzo Pieralisi <[email protected]>
Acked-by: Sergio Paracuellos <[email protected]>
  • Loading branch information
john-tho authored and Lorenzo Pieralisi committed Dec 6, 2022
1 parent 9abf231 commit 1909893
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/pci/controller/pcie-mt7621.c
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,8 @@ static int mt7621_pcie_register_host(struct pci_host_bridge *host)
}

static const struct soc_device_attribute mt7621_pcie_quirks_match[] = {
{ .soc_id = "mt7621", .revision = "E2" }
{ .soc_id = "mt7621", .revision = "E2" },
{ /* sentinel */ }
};

static int mt7621_pcie_probe(struct platform_device *pdev)
Expand Down

0 comments on commit 1909893

Please sign in to comment.