Fix bug in pydantic_model_creator
when include
does not contain foreing keys.
#1683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the function
pydantic_model_creator
is used to create a model and the parameterinclude
is passed #1430, this will raise an error if the relation is passed but not the foreign key value. Here is an example:The above code will raise a
KeyError
exception becausetournament
is not included, thus it will not be found infield_map
variable of the functionfield_map_update
. To fix this we can replace thedel
withpop
method.Checklist: