Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type hints for backends #1660

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

waketzheng
Copy link
Contributor

@waketzheng waketzheng commented Jun 18, 2024

Description

Improve type hints to reduce type:ignore

Motivation and Context

Improve type hint of tortoise/backends without changing any code logic

How Has This Been Tested?

make test

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

coveralls commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9559961752

Details

  • 38 of 45 (84.44%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 89.023%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/backends/oracle/client.py 1 2 50.0%
tortoise/contrib/mysql/fields.py 0 1 0.0%
tortoise/backends/oracle/executor.py 2 7 28.57%
Totals Coverage Status
Change from base Build 9543663341: -0.03%
Covered Lines: 5870
Relevant Lines: 6496

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9562810843

Details

  • 38 of 45 (84.44%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 89.023%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/backends/oracle/client.py 1 2 50.0%
tortoise/contrib/mysql/fields.py 0 1 0.0%
tortoise/backends/oracle/executor.py 2 7 28.57%
Totals Coverage Status
Change from base Build 9543663341: -0.03%
Covered Lines: 5870
Relevant Lines: 6496

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9565173623

Details

  • 38 of 45 (84.44%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 89.023%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/backends/oracle/client.py 1 2 50.0%
tortoise/contrib/mysql/fields.py 0 1 0.0%
tortoise/backends/oracle/executor.py 2 7 28.57%
Totals Coverage Status
Change from base Build 9563237685: -0.03%
Covered Lines: 5870
Relevant Lines: 6496

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9565355799

Details

  • 38 of 45 (84.44%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 89.024%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/backends/oracle/client.py 1 2 50.0%
tortoise/contrib/mysql/fields.py 0 1 0.0%
tortoise/backends/oracle/executor.py 2 7 28.57%
Totals Coverage Status
Change from base Build 9563237685: -0.03%
Covered Lines: 5870
Relevant Lines: 6496

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 30, 2024

Pull Request Test Coverage Report for Build 10194560214

Details

  • 49 of 55 (89.09%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 89.136%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/backends/oracle/client.py 2 3 66.67%
tortoise/backends/oracle/executor.py 2 7 28.57%
Totals Coverage Status
Change from base Build 10115140001: -0.02%
Covered Lines: 5944
Relevant Lines: 6557

💛 - Coveralls

@waketzheng
Copy link
Contributor Author

@abondar Only improve type hint, and does not change any code logic. Can this be accepted?

@abondar abondar merged commit c9c6775 into tortoise:develop Aug 1, 2024
7 checks passed
@waketzheng waketzheng deleted the type-hint-backends branch August 1, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants