Merge pull request eksctl-io#680 from wongma7/fixecrlogin

Fix outdated ecr login command
torredil · Jan 6, 2021 · b5c0756 · b5c0756
2 parents ddaa68b + ae26e4d
commit b5c0756
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/hack/run-e2e-test b/hack/run-e2e-test
@@ -80,7 +80,7 @@ if docker images | grep "${IMAGE_NAME}" | grep "${IMAGE_TAG}"; then
 else
   set -e
   loudecho "Building and pushing test driver image to ${IMAGE_NAME}:${IMAGE_TAG}"
-  eval "$(aws ecr get-login --region "${REGION}" --no-include-email)"
+  aws ecr get-login-password --region "${REGION}" | docker login --username AWS --password-stdin "${AWS_ACCOUNT_ID}".dkr.ecr."${REGION}".amazonaws.com
   docker build -t "${IMAGE_NAME}":"${IMAGE_TAG}" .
   docker push "${IMAGE_NAME}":"${IMAGE_TAG}"
 fi