refactors and route fix #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for torontojscom ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
usrrname
force-pushed
the
feat/route-fix
branch
from
f906817 to
058fda4
Compare
usrrname
force-pushed
the
feat/route-fix
branch
from
058fda4 to
0649c61
Compare
|
@kieran if routing ain't work on preview, but it works in local... sigh, maybe it's time to gut those crazy scripts and setup the router properly |
|
hi! is this issue finished or can i help out? :) |
|
@dreymoreau just waiting for peer review on this to merge in the refactors... otherwise as I see it there's all kinds of work:
|
refactor: rearranges page views into src/views folder refactor: extract components into separate .js files; creates Header for TJS animation refactor: creates Landing.js view for home page items, keep Splash as a layout page
usrrname
force-pushed
the
feat/route-fix
branch
from
0649c61 to
3090390
Compare
|
Only one way to find out.... shipping it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/p/volunteersNavBarandHeadercomponents, Header now contains TJS animation with vector backgroundLanding.jsas container for storing home page content instead of usingSplash.jssrc/views/, keep default exportKnown Issues
Hot module reloading doesn't work anymore