Add backwards-compatible locale verbose_name migration #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wagtail 6.2 alters the Locale model on TranslatableMixin, adding a verbose_name. Because Footnote inherits from TranslatableMixin, it needs a new migration generated for Wagtail 6.2. To maintain compatibility with Wagtail <= 6.1, this change makes the migration a noop. See torchbox#71 for context. Closes torchbox#71
zerolab
requested changes
Aug 13, 2024
There was a problem hiding this comment.
Thank you @willbarton (and @gasman for the excellent suggestion).
I am being cheeky and want to sneak in the removal of Wagtail 6.0 from the matrix.
LGTM otherwise
Co-authored-by: Dan Braghiș <[email protected]>
zerolab
approved these changes
Aug 13, 2024
|
Thank you so much, @zerolab! |
nickmoreton
pushed a commit
to torchbox-forks/wagtail-footnotes
that referenced
this pull request
Aug 20, 2024
* Add backwards-compatible locale verbose_name migration Wagtail 6.2 alters the Locale model on TranslatableMixin, adding a verbose_name. Because Footnote inherits from TranslatableMixin, it needs a new migration generated for Wagtail 6.2. To maintain compatibility with Wagtail <= 6.1, this change makes the migration a noop. See torchbox#71 for context. * Remove Wagtail 6.0 from test matrix Co-authored-by: Dan Braghiș <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wagtail 6.2 alters the Locale model on TranslatableMixin, adding a verbose_name. Because Footnote inherits from TranslatableMixin, it needs a new migration generated for Wagtail 6.2.
To maintain compatibility with Wagtail <= 6.1, this change makes the migration a noop for those versions. See #71 for context.
This PR also adds Wagtail 6.2 to the tox environments.
Closes #71