Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document setting X-Frame-Options for template errors #186

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Document setting X-Frame-Options for template errors #186

merged 2 commits into from
Jan 24, 2022

Conversation

bcdickinson
Copy link

@bcdickinson bcdickinson commented Jan 24, 2022 •
edited
Loading

Description

Document the need to set X_FRAME_OPTIONS for Django's debug views to work in the iframe UI.

Fixes #129

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

@bcdickinson bcdickinson self-assigned this Jan 24, 2022
@bcdickinson bcdickinson marked this pull request as ready for review January 24, 2022 17:01
thibaudcolas
thibaudcolas approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice!

@bcdickinson bcdickinson merged commit 4dacbd5 into main Jan 24, 2022
@bcdickinson bcdickinson deleted the document-x-frame-options branch January 24, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibaudcolas thibaudcolas thibaudcolas approved these changes

Assignees

@bcdickinson bcdickinson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Django 3+ debug error views don't set X-Frame-Options so aren't displayed in the iframe
2 participants
@bcdickinson @thibaudcolas