Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 UPGRADE: PyYAML to v6 #158

Merged
merged 2 commits into from
Dec 16, 2021

Conversation

simkimsia
Copy link
Contributor

Description

PyYAML is now v6. So trying to upgrade it to v6

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

@simkimsia
Copy link
Contributor Author

I have a project that relies on pattern-library and also using PyYAML. There's a conflict. Please upgrade PyYAML to v6

image

@simkimsia
Copy link
Contributor Author

@bcdickinson can help to review and merge this?

@simkimsia
Copy link
Contributor Author

simkimsia commented Dec 16, 2021

I receive an email abt the broken workflow run. Can teach me how to troubleshoot?

@thibaudcolas

@thibaudcolas
Copy link
Member

@simkimsia I believe this is the same error as we have on the main branch with Django’s dev branch, so nothing for you to worry about!

Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I was surprised there wasn’t an update to our poetry.lock, but it looks like we have it intentionally ignored by git so all good.

@thibaudcolas thibaudcolas merged commit 5d5c590 into torchbox:master Dec 16, 2021
@simkimsia
Copy link
Contributor Author

@thibaudcolas could you still educate me how to run tests locally?

@thibaudcolas
Copy link
Member

Sure – have a look at our CONTRIBUTING guidelines. We have three different ways to set up the project on there depending on your needs.

The simplest in my opinion is to use Poetry:

poetry install
poetry run ./runtests.py

@thibaudcolas thibaudcolas added django Related to Django templates capabilities enhancement New feature or request labels Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
django Related to Django templates capabilities enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants