Make it better compatibility with Django 3.2

[simkimsia]

Description

Include a default auto field in the apps.py as accordance to Django 3.2

Related to #153 as it's also about Django 3.2 compatibility but not the exact same issue

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have added an appropriate CHANGELOG entry

[tbrlpld]

@simkimsia I think the issue you are referencing in the PR description is describing a different deprecation.

Your PR fixes the default auto field: https://docs.djangoproject.com/en/3.2/releases/3.2/#customizing-type-of-auto-created-primary-keys

The issue is about the automatic app config discovery: https://docs.djangoproject.com/en/3.2/releases/3.2/#automatic-appconfig-discovery

Both changes come with Django 3.2 and relate to AppConfig but are distinct.

I would also propose to make the changelog entry more precise and really describe the change you made.

[simkimsia]

@tbrlpld i have changed the changelog and repush a new commit. Please check. Thank you

[tbrlpld]

@simkimsia "Better compatibility" still seems a bit subjective (which I understand is also only my subjective opinion 😅 ah irony).

How about :

Define `AppConfig.default_auto_field` as [required since Django 3.2](https://docs.djangoproject.com/en/3.2/releases/3.2/#customizing-type-of-auto-created-primary-keys).

[simkimsia]

I'll change to your suggestion

It sounds better too.

Later tonight I'll push

[simkimsia]

@tbrlpld done. pls check

[tbrlpld]

Looks good to me 👍

[simkimsia]

@tbrlpld merge?

[tbrlpld]

@simkimsia I do not have merge access in the repo. Maybe try mentioning a maintainer.

[simkimsia]

@tbrlpld thank you i wasn't aware.

@bcdickinson can help?

[thibaudcolas]

Thank you both, great to get this in!

@tbrlpld I’ve added you to the project’s maintainers.

[simkimsia]

@thibaudcolas thanks for merging. HOw do i become maintainer? and i noticed one of the compatibility tests failed. should i fix it?

[thibaudcolas]

@simkimsia at the moment all of the maintainers are Torchbox employees, although if you see yourself using this project and contributing regularly (big or small) I’m sure we’d consider it.