Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Django 4.2 #212

Closed
simkimsia opened this issue Apr 2, 2023 · 1 comment · Fixed by #220
Closed

Support Django 4.2 #212

simkimsia opened this issue Apr 2, 2023 · 1 comment · Fixed by #220

Comments

@simkimsia
Copy link
Contributor

Add support for Django 4.2rc1
This was referenced Apr 2, 2023
Closed
Closed
Closed
simkimsia added a commit to simkimsia/django-pattern-library that referenced this issue Apr 2, 2023
@simkimsia
Update tox.ini and pyproject.toml because tox upgraded
376a577 
In tox.ini:

- Replace whitelist_externals with allowlist_externals because whitelist_externals is deprecated
- Added isolated_build = True
- Remove install_command where it calls tox_install.sh
- Drop tool.poetry.dev-dependencies and switch to using tool.poetry.extras in order for tox to detect them

In ci.yml
- Because now use tool.poetry.extras so when call `poetry install` need to incldue `—extras ‘test’` as argument

The last 2 points about dropping dev-dependencies and using extras are from https://github.com/orgs/python-poetry/discussions/4307#discussioncomment-1041658

Fixes torchbox#212, torchbox#214, torchbox#215, torchbox#216, torchbox#218
This was referenced Apr 2, 2023
Closed
Merged
Open
@marts
Copy link

marts commented Jun 22, 2023

@simkimsia any movement on support for Django 4.2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@simkimsia @marts