Support/wagtail 50 #1
Conversation
lparsons396
commented
Oct 4, 2023
lparsons396
commented
- Support Wagtail 5.1
tox.ini
Outdated
| py{38,39,310}-django{3.2,4.1}-wagtail{4.1,4.2,5.0} | ||
| py{311}-django{4.1}-wagtail{4.1,4.2,5.0} | ||
| py{311}-django{4.2}-wagtail{5.0} | ||
| py{38,39,310}-django{3.2,4.1}-wagtail{4.1,4.2,5.0,5.1} |
There was a problem hiding this comment.
since we only support LTS and the last 2 non-LTS releases, 4.2 should drop from the list
https://endoflife.date/wagtail
There was a problem hiding this comment.
Gotcha, thanks for pointing me in the direction of endoflife too
CHANGELOG.md
Outdated
| @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| - Add Wagtail 5.1 support | |||
There was a problem hiding this comment.
| - Add Wagtail 5.1 support | |
| - Make Wagtail 5.1 support official |
tox.ini
Outdated
| py{38,39,310}-django{3.2,4.1}-wagtail{4.1,4.2,5.0} | ||
| py{311}-django{4.1}-wagtail{4.1,4.2,5.0} | ||
| py{311}-django{4.2}-wagtail{5.0} | ||
| py{38,39,310}-django{3.2,4.1}-wagtail{4.2,5.0,5.1} |
There was a problem hiding this comment.
Wagtail 4.1 is the LTS version. 4.2 is the one that needs dropping
|
@lparsons396 soo... I just noticed this PR is against torchbox-forks, rather than the actual repository 🙈 It would be great if you could open the PR against https://github.com/torchbox/wagtail-headless-preview as that is where it belongs ;) |
|
torchbox#50 was already merged. In the future, for our repos (i.e. in https://github.com/torchbox/) can we please always open a PR against the main repo rather than on the fork |
Thanks @zerolab it makes sense. I'll need to communicate that somehow, are you likely to code review them or could it be someone else? |
|
It helps having someone else do a code review, but it is the maintainer's job to do a final one |
