Started a memory viewer, need to add breakpoints #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I found out the big memory leak is caused by the If you comment those out, and export an empty object. no more leak between refresh 😄 |
|
Sorry but gonna use this to track memory leak. So it seems like it may have something to do with Going to assume it has something to do with how we are passing around WasmBoy. |
|
Found the memory leak: https://github.com/torch2424/wasmboy/blob/master/lib/wasmboy/wasmboy.js#L38 Seems like chrome doesn't like firing off promises on the visibility events 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #226
Started a memory viewer, and abstracted all of the virtual list type code stuff. Also, found a huge memory issue in relaying messages, and getting an infinite message listening for our smart workers.
This PR is only half done. but merging now because the between-refresh memory leak is bothering me 😠