Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Inserting Boot ROM #92

Closed
Tracked by #197
torch2424 opened this issue Apr 28, 2018 · 0 comments · Fixed by #267
Closed
Tracked by #197

Add Support for Inserting Boot ROM #92

torch2424 opened this issue Apr 28, 2018 · 0 comments · Fixed by #267
Assignees
@torch2424
Labels
Core/Wasm Issues concerning the core library of Wasmboy enhancement New feature or request Lib / JS Issues concerning the JS API of WasmBoy

Comments

@torch2424
Copy link
Owner

torch2424 commented Apr 28, 2018 •
edited
Loading

We need to add memory for inserting a boot rom (0x100), and we should remove the "currently rendered frame", since it did not fix anything, and took up precious perf time.

And then implementing running the boot ROM if loaded
@torch2424 torch2424 self-assigned this Apr 28, 2018
@torch2424 torch2424 changed the title Update Memory Map Add Support for Inserting Boot ROM Sep 20, 2018
@torch2424 torch2424 added enhancement New feature or request Core/Wasm Issues concerning the core library of Wasmboy Lib / JS Issues concerning the JS API of WasmBoy labels Sep 20, 2018
@torch2424 torch2424 mentioned this issue Nov 12, 2018
Open
60 tasks
@torch2424 torch2424 mentioned this issue Feb 24, 2019
Merged
torch2424 added a commit that referenced this issue Feb 28, 2019
@torch2424
Added support for adding boot roms, and some other bugs (#267)
dbf5723 
closes #92 
closes #191 

* Adds support for setting a GB or GBC boot ROM. Which correlates to the type of ROM being loaded
* General cleanup around core initialization
* Fixed a weird bug I had where Safari `new window.webkitAudioContext()` was null.
* Fixed the options not being truthful on load. (Was fixed after the gif)
* Fixed boot ROM for headless
* Move around the dist files so they wont be in the PRs any more 😄 

# Example

A big ol' 2 minute gif on loading / not loading ROMs with boot ROMs

![bootromwasmboy](https://user-images.githubusercontent.com/1448289/53296808-b7e90780-37c8-11e9-80f0-74ef9537a847.gif)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@torch2424 torch2424

Labels
Core/Wasm Issues concerning the core library of Wasmboy enhancement New feature or request Lib / JS Issues concerning the JS API of WasmBoy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added support for adding boot roms, and some other bugs torch2424/wasmboy
1 participant
@torch2424