Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about paste expiration, cosmetic fixes. #192

Merged
merged 2 commits into from
Dec 31, 2017

Conversation

C0rn3j
Copy link
Contributor

@C0rn3j C0rn3j commented Dec 29, 2017

adds a note about file storage paste expiration, as discussed in #191

README.md Outdated
Where `path` represents where you want the files stored
where `path` represents where you want the files stored.

File storage currently does not support paste expiration, you can follow [#191](/../../issues/191) for status updates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we link to the issue here we need to use an absolute link, otherwise those viewing this not on GitHub will have no context. Also, I'm not sure about including the issue in the status

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've converted the path to an absolute one.

As for including a status issue in the readme - I see nothing wrong with that and find it neat for people who would welcome that feature, as they can just instantly view the issue and subscribe to it.

Up to you if you want to keep it there though.

@seejohnrun seejohnrun merged commit 0a8923b into toptal:master Dec 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants