This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
0.28 #245
Merged
0.28 #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
peterschutt
commented
Jan 15, 2023
•
peterschutt
commented
- feat(sentry): add starlite sentry integration (feat(sentry): add starlite sentry integration #239)
- feature(testing): pytest plugin (feature(testing): pytest plugin #246)
- ci: pin deps
- refactor: use constants for test/local env checks.
- feature: run-app entrypoint
- fix: ignore 405s in ControllerTest utility.
* ✨ feat(sentry): add starlite sentry integration * ✅ test(sentry): add traces sampler test * feat(sentry): disabled by default if environment "local" or "test" Co-authored-by: Peter Schutt <[email protected]>
Adds an initial pass at a pytest plugin for testing `starlite-saqlalchemy` applications. Includes the following fixtures: * `is_unit_test`: a boolean that distinguishes between unit and integration tests * `_patch_http_close`: an autouse fixture that prevents any globally instantiated http clients being closed between tests * `_patch_sqlalchemy_plugin`: autouse fixture that patches the sqlalchemy plugin `on_shutdown` method for unittests * `_patch_worker`: autouse fixture that patches the worker `on_app_startup` and `stop` methods for unit tests * `app`: fixture that uses a defined import path to inject an application instance. Default path is `app.main:create_app` * `client`: fixture that injects a starlite `TestClient` instance bound to the same app given by the `app` fixture * `cap_logger`: a structlog capturing logger for inspecting log output Closes #106 Closes #232
Better to let dependabot manage these for us too.
We are starting to amass a bit of functionality that is condition upon the environment setting. E.g., sentry init disabled by default in test and local environments, alternate logging config if environment is local, and server reloading automatically configured for local environment. So, it makes sense to have a bit more structure around these checks. Closes #244
With starlite-saqlalchemy installed, calling `run-app` will execute `starlite_saqlalchemy.scripts.run_app()`. Closes #243
If a method handler isn't registered, we ignore that test. Closes #234
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.