Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Service: consider not using NotImplementedError #179

Closed
peterschutt opened this issue Dec 18, 2022 · 0 comments
Closed

Service: consider not using NotImplementedError #179

peterschutt opened this issue Dec 18, 2022 · 0 comments

Comments

@peterschutt
Copy link
Member

Tools like pylint and pycharm inspections warn that these should be overridden, even though the base class isn't an explicit ABC.

Maybe just have default methods that are no-op, i.e., but not sure how that would work for something like create() where the method needs to return an instance of the type..

peterschutt added a commit that referenced this issue Jan 11, 2023
This requires the methods to have a default functionality, so:

- list method returns an empty list
- create, update/upsert methods return the object, untouched.
- get and delete methods raise NotFoundError

closes #179
peterschutt added a commit that referenced this issue Jan 11, 2023
This requires the methods to have a default functionality, so:

- list method returns an empty list
- create, update/upsert methods return the object, untouched.
- get and delete methods raise NotFoundError

closes #179
peterschutt added a commit that referenced this issue Jan 11, 2023
This requires the methods to have a default functionality, so:

- list method returns an empty list
- create, update/upsert methods return the object, untouched.
- get and delete methods raise NotFoundError

closes #179
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant