feat: add volta packages #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diogonr
force-pushed
the
feat/volta-packages
branch
2 times, most recently
from
dbfb5ef
to
a344b7e
Compare
SteveLauC
requested changes
Aug 1, 2024
add print_info when no packages found apply review feedback
diogonr
force-pushed
the
feat/volta-packages
branch
from
31dd0f8
to
f0df986
Compare
|
Thank for the feedback, i'm clueless in rust... Suggestions applied, and retested locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Currently there's no volta upgrade command, so this implementation has to list all installed packages first, and update them separately
Example output:
Standards checklist
CONTRIBUTING.mdFor new steps
--dry-runoption works with this step--yesoption works with this step if it is supported bythe underlying command