[V2] refactor(agent): channel capacity as histogram #429
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hspedro
force-pushed
the
refactor/agent-buffer-msg-metric
branch
from
d4b25db to
5b6d6d5
Compare
Channel capacity is a metric of each agent, that is created in each handle so the capacity varies depending on the client/agent being used and we need to differentiate the lows/highs of each in the metric. Adding a client label to the Gauge is not feasible, since it'd explode cardinality. Thus, adding a new metric as an histogram so we maintain compat until deprecating the old gauge one
hspedro
force-pushed
the
refactor/agent-buffer-msg-metric
branch
from
8fb20e7 to
b731857
Compare
reinaldooli
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Connectors with agents reaching 0 capacity but metric still report as full capacity
Reason
Channel capacity is a metric of each agent, that is created in each handle so the capacity varies depending on the client/agent being used and we need to differentiate the lows/highs of each in the metric.
Solution
Adding a client label to the Gauge is not feasible, since it'd explode cardinality. Thus, adding a new metric to be an Histogram so we can capture the highs and lows. The old one will be deprecated one we migrate all graphs to use the new one