Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Challenge activation issues #993

Closed
maxceem opened this issue Dec 15, 2020 · 3 comments
Closed

Challenge activation issues #993

maxceem opened this issue Dec 15, 2020 · 3 comments
Assignees
@maxceem
Labels
Goal Release By: 12/30 P1 QA Pass in Prod
Milestone
0.3.0

Comments

@maxceem
Copy link
Contributor

maxceem commented Dec 15, 2020 •
edited
Loading

  1. If some error happens (for example billing account is not attached) during challenge activation from the details view page, the popup is closed without showing an error, see demo video https://monosnap.com/file/JRDUbei6SjypqxBdbcBDTclQl1JX2q (this works good from the list page https://monosnap.com/file/GYSIqMRmDocJq9qmbXpUj6XvGABCFJ)

  2. If the challenge is activated successfully from the details view page it is not moved to the active tab immediately and is still shown on the Draft tab https://monosnap.com/file/hhFa8Yx0IgBvaXkAQDqIqicsnaSPKO

  3. The challenge is not going to Active tab, when activating form the Draft tab list https://monosnap.com/file/NMOtQvHxdCu1zxifMkfstU2S8Qmymi
maxceem added a commit to maxceem/work-manager that referenced this issue Dec 15, 2020
@maxceem
fix: change status of active challenge form list
4339ec1 
ref issue topcoder-platform#993
maxceem added a commit to maxceem/work-manager that referenced this issue Dec 15, 2020
@maxceem
fix: change status on launch from details
a573722 
ref issue topcoder-platform#993
@maxceem maxceem mentioned this issue Dec 15, 2020
Merged
@maxceem
Copy link
Contributor Author

maxceem commented Dec 15, 2020

@vikasrohit Fixed by #994. Verifications videos:

  1. https://monosnap.com/file/5voZpuyEhcknJwTTLTeFWyeVokXtyo

  2. https://monosnap.com/file/NEhKmoSMrtWpAFwKUXz8NQm6hFFZak

  3. https://monosnap.com/file/u9FzEuoAsyIb572CZ9slJXRN3bVR2Q

@maxceem maxceem self-assigned this Dec 15, 2020
vikasrohit pushed a commit that referenced this issue Dec 16, 2020
Merge pull request #994 from maxceem/issue-993
44f7cc0 
fix: Challenge activation issues #993
@vikasrohit vikasrohit added P2 P1 and removed P2 labels Dec 16, 2020
@vikasrohit vikasrohit added this to the 0.3.0 milestone Dec 16, 2020
@vikasrohit
Copy link

Thanks @maxceem

@vikasrohit vikasrohit mentioned this issue Dec 16, 2020
Merged
@lakshmiathreya
Copy link

Verified Activation via Listing and View Challenge in Prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxceem maxceem

Labels
Goal Release By: 12/30 P1 QA Pass in Prod
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
4 participants
@maxceem @vikasrohit @acshields @lakshmiathreya