Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix contentful not working june222023 #6894

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Hotfix contentful not working june222023 #6894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d45df0
Revert "fix: return placeholder if items empty"
jmgasper Jun 22, 2023
7b2d30b
Deploy hotfix to staging for validation
jmgasper Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,7 @@ workflows:
branches:
only:
- develop
- HOTFIX_Contentful_Not_Working_June222023
# Production builds are exectuted
# when PR is merged to the master
# Don't change anything in this configuration
Expand Down
2 changes: 1 addition & 1 deletion src/shared/containers/ContentfulLoader.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ class ContentfulLoader extends React.Component {

/* Some of the required data still pending to load: render a placeholder,
* or nothing. */
if (!data || _.isEmpty(Object.values(data.entries.items))) {
if (!data) {
return _.isFunction(Placeholder) ? <Placeholder /> : Placeholder;
}

Expand Down