Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counter: true makes max show up as value #49

Closed
jgentes opened this issue Apr 1, 2013 · 6 comments
Closed

counter: true makes max show up as value #49

jgentes opened this issue Apr 1, 2013 · 6 comments

Comments

@jgentes
Copy link

jgentes commented Apr 1, 2013

Refreshmax works great, btw, so thanks for that feature!

Counter is very cool. However I noticed that when I turn it on, in some cases (couldn't nail down the root cause) the max value was used instead of the actual value field. This happened when putting specific #'s into the value: field. Here's an example.. value: 520, min: 0, max 77, so maybe something to do with the max being less than the value.

Also looks like showMinMax doesn't work any more. They are always showing. Decimals seems to work well!

@toorshia
Copy link
Owner

toorshia commented Apr 2, 2013

I'll check this, thanks for reporting.

@toorshia
Copy link
Owner

toorshia commented Apr 2, 2013

"showMinMax" has been changed to "hideMinMax", for the reasons of me being stupid at times (as stated in push comment when it was changed) :) Please update your setup.

@jgentes
Copy link
Author

jgentes commented Apr 2, 2013

ah, got it - thanks!

On Tue, Apr 2, 2013 at 2:23 AM, Bojan Djuricic [email protected]:

"showMinMax" has been changed to "hideMinMax", for the reasons of me being
stupid at times (as stated in push comment when it was changed) :) Please
update your setup.


Reply to this email directly or view it on GitHubhttps://github.com//issues/49#issuecomment-15765051
.

toorshia added a commit that referenced this issue Apr 17, 2013
toorshia added a commit that referenced this issue Apr 17, 2013
toorshia added a commit that referenced this issue Apr 17, 2013
@toorshia
Copy link
Owner

Should work now, please test :)

@surfacedamage
Copy link

The "customize style" section on justgage.com also needs updated to reflect this change. Thanks!

@toorshia
Copy link
Owner

toorshia commented Jun 5, 2013

You are so right :) Website has been neglected completely...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants