Add keySelectorCreator option #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toomuchdesign
force-pushed
the
key-selector-creator-option
branch
4 times, most recently
from
e485757 to
8e8f6e9
Compare
toomuchdesign
force-pushed
the
key-selector-creator-option
branch
from
8e8f6e9 to
cac3298
Compare
toomuchdesign
force-pushed
the
key-selector-creator-option
branch
from
cac3298 to
448be75
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behaviour? (You can also link to an open issue here)
#73
What is the new behaviour?
Add
keySelectorCreatoroption to provide an hook to dynamically generatekeySelectorsbased on providedinputSelectors,resultFuncandkeySelector.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
This is a partial release of a wider feature aiming to provide a way of composing automagically
cachedSelectors. See:Please check if the PR fulfills these requirements: