Skip to content

Commit

Permalink
refactor: minor improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
toomuchdesign committed Dec 10, 2023
1 parent 4d4c82c commit 0eeb7a9
Show file tree
Hide file tree
Showing 6 changed files with 165 additions and 168 deletions.
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -455,8 +455,9 @@ Get `keySelector` for utility compositions or testing.

## Todo's

- Improve TS tests readability
- More examples
- Improve tests readability
- Port to native TS based on reselect v5 approach
- Find out whether `re-reselect` should be deprecated in favour of `reselect` memoization/cache options

## Contributors

Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"test:typescript": "tsc --noEmit",
"test:bundles": "npm run test:bundles:snapshot && npm run test:bundles:unit",
"test:bundles:unit": "jest ./src --config ./jest/es.config.js && jest ./src --config ./jest/cjs.config.js && jest ./src --config ./jest/umd.config.js",
"test:bundles:snapshot": "jest ./jest/bundles-snapshot.test.js",
"test:bundles:snapshot": "jest ./jest/bundles-snapshot.test.ts",
"test:source": "npm run test:typescript && npm run test -- --coverage",
"test:update": "npm run compile && npm run test:bundles:snapshot -- -u",
"clean": "rimraf dist",
Expand Down
6 changes: 1 addition & 5 deletions src/__tests__/createCachedSelector.test.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
import * as reselect from 'reselect';
import createCachedSelectorAsDefault, {
createCachedSelector,
FlatObjectCache,
ICacheObject,
} from '../index';
import {createCachedSelector, FlatObjectCache, ICacheObject} from '../index';

// Cannot natively spyOn es module named exports
jest.mock('reselect', () => ({
Expand Down
Loading

0 comments on commit 0eeb7a9

Please sign in to comment.