Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: generate schemas in different paths #78

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Conversation

toomuchdesign
Copy link
Owner

What kind of change does this PR introduce?

Test refactor

What is the current behaviour?

Tests used to dynamically import generated schemas by appending ?update=${Date.now() to the import path to get a fresh value of the imported modules.

What is the new behaviour?

Make sure to always generated schemas in different directories to avoid unexpected ES module cache issues.

Does this PR introduce a breaking change?

No

Other information:

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added
  • Docs have been added / updated
  • Relevant Changeset has been added

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2023

⚠️ No Changeset found

Latest commit: fea67df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@toomuchdesign toomuchdesign changed the title test: remove import fresh test: generate schemas in different paths Sep 18, 2023
@github-actions
Copy link
Contributor

Coverage Status

coverage: 100.0%. remained the same when pulling fea67df on remove-import-fresh into 9e0a222 on master.

@toomuchdesign toomuchdesign merged commit 3798318 into master Sep 18, 2023
4 checks passed
@toomuchdesign toomuchdesign deleted the remove-import-fresh branch September 18, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant