Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generated $ref schemas when $refed with different descriptions #252

Merged
merged 3 commits into from
May 15, 2024

Conversation

toomuchdesign
Copy link
Owner

@toomuchdesign toomuchdesign commented May 14, 2024

What kind of change does this PR introduce?

Bug fix

What is the current behaviour?

Same $ref declared with different description prop not being imported properly

What is the new behaviour?

$ref getting imported as expected no matter their description

Does this PR introduce a breaking change?

No

Other information:

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added
  • Docs have been added / updated
  • Relevant Changeset has been added

Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: f85963d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-ts-json-schema Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link
Collaborator

coveralls commented May 14, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling 6dbca05 on fix-refs-with-different-description
into 8cc1522 on master.

@toomuchdesign toomuchdesign force-pushed the fix-refs-with-different-description branch from e0a2963 to de64ea6 Compare May 15, 2024 07:16
@toomuchdesign toomuchdesign changed the title fix: handle schemas with different descriptions fix: generated $ref schemas when $refed with different descriptions May 15, 2024
@toomuchdesign toomuchdesign force-pushed the fix-refs-with-different-description branch from de64ea6 to 6dbca05 Compare May 15, 2024 07:30
@toomuchdesign toomuchdesign merged commit 6d55193 into master May 15, 2024
5 checks passed
@toomuchdesign toomuchdesign deleted the fix-refs-with-different-description branch May 15, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants