Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle OpenAPI props not convertible to JSON schemas #197

Merged
merged 4 commits into from
Mar 9, 2024

Conversation

toomuchdesign
Copy link
Owner

@toomuchdesign toomuchdesign commented Mar 6, 2024

What kind of change does this PR introduce?

Bug fix

What is the current behaviour?

Current JSON schema conversion strategy is too liberal In trying to convert any OpenAPI prop to JSON schema.

See #186

What is the new behaviour?

...

Does this PR introduce a breaking change?

What changes might users need to make in their application due to this PR?

Other information:

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added
  • Docs have been added / updated
  • Relevant Changeset has been added

Copy link

changeset-bot bot commented Mar 6, 2024

🦋 Changeset detected

Latest commit: 2833956

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-ts-json-schema Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@toomuchdesign toomuchdesign linked an issue Mar 6, 2024 that may be closed by this pull request
@toomuchdesign toomuchdesign changed the title fix: handle OpenAPI props not convertible to JSON schemas. fix: handle OpenAPI props not convertible to JSON schemas Mar 6, 2024
@coveralls
Copy link
Collaborator

coveralls commented Mar 8, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling 2833956 on security-fields
into 5ca3a8d on master.

@toomuchdesign toomuchdesign force-pushed the security-fields branch 2 times, most recently from 1b82f2d to 918bc9d Compare March 8, 2024 17:09
@toomuchdesign toomuchdesign merged commit b88000d into master Mar 9, 2024
5 checks passed
@toomuchdesign toomuchdesign deleted the security-fields branch March 9, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security schema fails on type: http
2 participants