Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support windows #191

Merged
merged 12 commits into from
Mar 5, 2024
Merged

fix: support windows #191

merged 12 commits into from
Mar 5, 2024

Conversation

toomuchdesign
Copy link
Owner

@toomuchdesign toomuchdesign commented Mar 4, 2024

What kind of change does this PR introduce?

Fix

What is the current behaviour?

openapi-ts-json-schema doesn't work on Windows. See #187

What is the new behaviour?

Setup a windows CI and fix failing tests

Does this PR introduce a breaking change?

Yes

  • schemaFileName meta data prop removed
  • PluginInput['makeRelativePath'] type renamed to PluginInput['makeRelativeModulePath']
  • _ used as path separator instead of |

Other information:

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added
  • Docs have been added / updated
  • Relevant Changeset has been added

Copy link

changeset-bot bot commented Mar 4, 2024

🦋 Changeset detected

Latest commit: ea05983

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-ts-json-schema Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: Andrea Carraro <[email protected]>
@toomuchdesign toomuchdesign force-pushed the windows-ci branch 2 times, most recently from 8ae58ca to 44d4b3d Compare March 4, 2024 16:54
@toomuchdesign toomuchdesign changed the title chore: setup multi os pipeline chore: support windows Mar 4, 2024
@toomuchdesign toomuchdesign changed the title chore: support windows fix: support windows Mar 4, 2024
@toomuchdesign toomuchdesign force-pushed the windows-ci branch 5 times, most recently from 07f9365 to f1c8931 Compare March 4, 2024 22:39
@coveralls
Copy link
Collaborator

coveralls commented Mar 4, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling ea05983 on windows-ci
into c3689cc on master.

@toomuchdesign toomuchdesign merged commit a418ecb into master Mar 5, 2024
5 checks passed
@toomuchdesign toomuchdesign deleted the windows-ci branch March 5, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fastify plugin generates module with an invalid path
2 participants