This repository has been archived by the owner on Feb 26, 2019. It is now read-only.
Consider "AUTHORS" and "CONTRIBUTORS" legal files #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some packages, such as github.com/tchap/go-patricia, have an AUTHORS file to list the names of the copyright holders. Some packages include a CONTRIBUTORS file that licenses refer to. For example golang.org/x/sys/LICENSE and golang.org/x/sys/CONTRIBUTORS
aaronbee
changed the title
|
LGTM |
This avoids a call to parse all go files, which chokes on files using go18's type aliasing features.
|
This PR changes much more than that though. Please remove the other changes or describe why they were necessary. |
|
My bad. I didn't mean to add those other changes to this PR. |
|
I created a new PR: #522 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some packages, such as github.com/tchap/go-patricia, have an AUTHORS
file to list the names of the copyright holders.