substitute pkg_resources with importlib_metadata #212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #167 Previously, the correct parent assignment for tasks only worked if expandtab was set in vim: if the task currently checked did not start with the indentation of the new task, the current line was assigned as the parent. taskwiki uses spaces for indentation, with a fixed length of 4 [0]. If vim is set to use tabs instead of spaces, the checked line does not start with tabs and is assigned the parent, even if the actually indentation is the same. Especially hard-coding the number of spaces for the indentation should maybe be fixed in the future. [0] https://github.com/tbabej/taskwiki/blob/0c964460e6bbfba387b8a2976a3c349aa615e525/taskwiki/sort.py#L170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #183.