feat: Set of patches for our instance #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: Track ldap status from Net::LDAP::PDU response * fix: Add extra attribute for tracking false ldap error * fix: OpenTelemetry error for NilClass * fix: Ignore message & error_message if empty
* fix: Add graphql variables to the trace results * fix: add tests
jdehaan
force-pushed
the
chore/2024-02-05-rebase
branch
2 times, most recently
from
3fdac5a to
220bd7e
Compare
jdehaan
force-pushed
the
chore/2024-02-05-rebase
branch
from
220bd7e to
b6d0617
Compare
jdehaan
changed the title
|
Created branch based on this PR: main-aoeur-20240205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After having a clean rebased PR we can keep that branch and make a tag used inside our software to reference to it.
On new upstream changes we can repeat the process and avoid having to deal with complicated merges