Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new pet chicken #339

Merged
merged 9 commits into from
Dec 9, 2022
Merged

Add new pet chicken #339

merged 9 commits into from
Dec 9, 2022

Conversation

MhouneyLH
Copy link
Contributor

This is connected to issue #242

I changed all necessary things. (or at least I think that I have done this) I tested it and the extension creates the chicken, but it does not get displayed in the frame. Now I don't really know what to do anymore to get it working. :/

Additionally I get errors from the translation files, but I guess, that this has nothing to do with the new chicken-pet.
image

@tonybaloney
Copy link
Owner

Make sure you're running a newer version of vs code. Also open up the Developer Console to see any runtime errors

@MhouneyLH
Copy link
Contributor Author

MhouneyLH commented Dec 8, 2022

I forgot to compile the whole project and because of this the chicken could not load. 😂
image

@gulyapulya
Copy link
Contributor

Love your chicken names list, 'Albert Eggstein' 😂 this is masterpiece 🤌🏼

@codecov-commenter
Copy link

Codecov Report

Merging #339 (4baf824) into master (76aca9f) will decrease coverage by 2.00%.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage   16.35%   14.34%   -2.01%     
==========================================
  Files          18       17       -1     
  Lines        1107      774     -333     
  Branches      152      103      -49     
==========================================
- Hits          181      111      -70     
+ Misses        917      663     -254     
+ Partials        9        0       -9     
Impacted Files Coverage Δ
src/common/types.ts 71.42% <ø> (ø)
src/panel/pets.ts 19.79% <33.33%> (+0.43%) ⬆️
src/panel/pets/chicken.ts 50.00% <50.00%> (ø)
src/extension/extension.ts
src/common/localize.ts

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tonybaloney
Copy link
Owner

tonybaloney commented Dec 9, 2022

screenshot 2022-12-09 at 15 42 53

Love it!! 👍🏻

@tonybaloney tonybaloney merged commit 0ad77ab into tonybaloney:master Dec 9, 2022
tonybaloney added a commit that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants