Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cats sizes when ball catched #313

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

gulyapulya
Copy link
Contributor

@gulyapulya gulyapulya commented Nov 18, 2022

Fixes #304

Problem:

When any cat (brown, white, black) catches a ball, the cat's image gets noticeably larger.

Solution:

The problem was not in the code but in the gifs of the cat images. I have adjusted the cats' gifs when holding a ball and now, they look similar to the size when idle and running.

Please let me know if any changes should be made.

Demo:

image
image

@codecov-commenter
Copy link

Codecov Report

Merging #313 (7de97a6) into master (44f7068) will increase coverage by 2.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
+ Coverage   15.06%   17.34%   +2.28%     
==========================================
  Files          17       19       +2     
  Lines         697     1049     +352     
  Branches       93      148      +55     
==========================================
+ Hits          105      182      +77     
- Misses        592      859     +267     
- Partials        0        8       +8     
Impacted Files Coverage Δ
src/common/localize.ts 63.63% <0.00%> (ø)
src/extension/extension.ts 20.23% <0.00%> (ø)
src/common/names.ts 86.66% <0.00%> (+6.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tonybaloney
Copy link
Owner

Brilliant, thank you

@tonybaloney tonybaloney merged commit 1445f69 into tonybaloney:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cat with ball is the wrong ratio
3 participants