Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mod and refactor to smaller files #296

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

marcduiker
Copy link
Contributor

@marcduiker marcduiker commented Oct 31, 2022

Next to adding Mod the dotnet bot, I also refactored quite a bit to avoid having very large files. I hope this will make future contributions for new pets (or names) a bit easier. I needed to more move than intended to avoid circular dependencies 😬.
If you don't want this as part of this PR let me know.

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2022

Codecov Report

Merging #296 (cbbaa8d) into master (ac75fc0) will increase coverage by 0.55%.
The diff coverage is 24.89%.

@@            Coverage Diff             @@
##           master     #296      +/-   ##
==========================================
+ Coverage   14.52%   15.08%   +0.55%     
==========================================
  Files           7       17      +10     
  Lines        1005      696     -309     
  Branches      147       92      -55     
==========================================
- Hits          146      105      -41     
+ Misses        851      591     -260     
+ Partials        8        0       -8     
Impacted Files Coverage Δ
src/common/types.ts 71.42% <ø> (ø)
src/panel/states.ts 16.56% <ø> (ø)
src/panel/basepettype.ts 2.87% <2.87%> (ø)
src/panel/pets/rocky.ts 37.50% <37.50%> (ø)
src/panel/pets/cat.ts 42.85% <42.85%> (ø)
src/panel/pets/clippy.ts 42.85% <42.85%> (ø)
src/panel/pets/cockatiel.ts 42.85% <42.85%> (ø)
src/panel/pets/crab.ts 42.85% <42.85%> (ø)
src/panel/pets/dog.ts 42.85% <42.85%> (ø)
src/panel/pets/mod.ts 42.85% <42.85%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tonybaloney tonybaloney self-requested a review October 31, 2022 20:36
@tonybaloney
Copy link
Owner

Adjusted the English description of mod, so it says "Mod (the .NET bot)" in the dropdown to aid discoverability.

@tonybaloney
Copy link
Owner

Great contribution! Thanks Marc

@tonybaloney
Copy link
Owner

screenshot 2022-11-01 at 08 46 38

@tonybaloney tonybaloney merged commit 1d4f67b into tonybaloney:master Oct 31, 2022
tonybaloney added a commit that referenced this pull request Feb 26, 2023
Add Mod and refactor to smaller files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants